Conversation
This was referenced Sep 4, 2020
CKehl
approved these changes
Sep 7, 2020
angus-g
reviewed
Sep 9, 2020
Contributor
angus-g
left a comment
angus-g
left a comment
There was a problem hiding this comment.
It does seem like this will make it a bit easier to configure different compilers!
I've got a few comments about structure: there's quite a lot of duplication between different compiler configs, and they're pretty verbose.
CKehl
reviewed
Sep 18, 2020
1 task
angus-g
suggested changes
Nov 27, 2020
Contributor
angus-g
left a comment
angus-g
left a comment
There was a problem hiding this comment.
This looks like it should work for the moment, although I haven't tested the extension to the non-GCC compilers. Importantly, it respects CC for non-MPI compilation (although in MPI mode it will always use mpicc).
Just one problem with the specification of the linker flags that I can see, otherwise seems fine!
CKehl
added a commit
that referenced
this pull request
Dec 1, 2020
CKehl
force-pushed
the
refactoring_compiler
branch
from
5978a8f to
c72eed9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #869, and supports external libraries and multiple source files in the Compiler
Thanks to @CKehl, from whose #862 most of these changes were lifted